Drop @tailwindcss/line-clamp warning
#10915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This won't work in places where `require` calls are hoisted so that they become static imports. This means that in some projects this `require` call was breaking the full application even though it was intentionally put in a try/catch block...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where applications could break when using the new Tailwind CSS v3.3.0 version.
This happens because we're trying to detect whether or not the
@tailwindcss/line-clampplugin is being used by conditionally requiring it. This is done because the line-clamp plugin is now part of Tailwind CSS itself, and so the plugin is no longer required.Unfortunately some build tools hoist conditional
requirecalls as static imports, even if they are inside of atry/catchblock, causing build failures when the@tailwindcss/line-clamppackage is not installed.To solve this we removed this warning from Tailwind CSS and are instead including it in the latest patch version of the
@tailwindcss/line-clampplugin (tailwindlabs/tailwindcss-line-clamp#26).Unfortunately this means that, unless the user updates to the latest version of the
@tailwindcss/line-clampplugin, we can no longer automatically disable the line-clamp plugin — which could result in having duplicated CSS entries for the line-clamp utilities. The good news is that this doesn't actually break your UI, it just results in a bit of extra CSS in the final output.Fixes: #10894