Ensure multiple theme(spacing[5]) calls with bracket notation in arbitrary properties work
#11039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
changed the title
theme(spacing.[5]) calls with bracket notation in arbitrary properties worktheme(spacing[5]) calls with bracket notation in arbitrary properties work
Given this input: ```html <div class="[width:_calc(theme(spacing[5])_+_theme(spacing[5]))]"></div> ``` Then we would expect the match to be this: ``` [width:_calc(theme(spacing[5])_+_theme(spacing[5]))] ``` However, with the `?`, then it would stop and result in: ``` [width:_calc(theme(spacing[5])_+_theme(spacing[5] ``` Which makes it incomplete because the `))]` are missing at the end.
RobinMalfait
force-pushed
the
fix/issue-11034
branch
from
67173f8
to
9f84ad3
Compare
This was referenced May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where multiple calls using
theme(spacing[5])with arbitrary properties wouldn't be matched completely.The issue is that the brackets
Given this input:
Then we would expect the match to be this:
However, before this change, it would stop too early and it results in:
Which makes it incomplete because the
))]are missing at the end.This also means that the matched candidate (class in your html) is incomplete and not valid.
Fixes: #11034