Normalize arbitrary modifiers #11057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies the same rules as arbitrary values. The `_` can be used in place of a space. If you _do_ want an underscore, you can escape it with `\_` (`\\_` in JavaScript).
RobinMalfait
force-pushed
the
fix/issue-11045
branch
from
27d0aa6
to
088a8ab
Compare
This was referenced May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where arbitrary modifiers are not treated the same as arbitrary values.
Currently it is not possible to use underscores (
_) in arbitrary modifiers because they stay there as-is instead of getting replaced by spaces.This PR makes sure that the arbitrary modifiers are normalized, it will use the same rules as arbitrary values. This means that you should be able to use
_instead of a space. If you do want to keep the_then you have to escape it using\_.Fixes: #11045