Fix box-sizing for shadow-dom elements
#1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamwathan could you take a look at this for v1.2.0? Let me know if you need me to change/research/test anything before merging. I'm not as afk as I was last week :D |
|
Seems good, thanks! |
maco
added a commit
to maco/react-spinners
that referenced
this pull request
Feb 14, 2020
Recent versions of Tailwind CSS force everything to `box-sizing: border-box;` (see tailwindlabs/tailwindcss#1111 ) Tailwind isn't the only thing out there using that hack, so this is sure to be a wider-ranging problem. The result of using Tailwind & react-spinners in the same project without this change is that the spinner circle wobbles around.
davidhu2000
added a commit
to davidhu2000/react-spinners
that referenced
this pull request
May 2, 2020
Recent versions of Tailwind CSS force everything to `box-sizing: border-box;` (see tailwindlabs/tailwindcss#1111 ) Tailwind isn't the only thing out there using that hack, so this is sure to be a wider-ranging problem. The result of using Tailwind & react-spinners in the same project without this change is that the spinner circle wobbles around. Co-authored-by: David Hu <davidhu314@gmail.com>
scottju1
added a commit
to scottju1/react-spinners
that referenced
this pull request
Jun 13, 2023
Recent versions of Tailwind CSS force everything to `box-sizing: border-box;` (see tailwindlabs/tailwindcss#1111 ) Tailwind isn't the only thing out there using that hack, so this is sure to be a wider-ranging problem. The result of using Tailwind & react-spinners in the same project without this change is that the spinner circle wobbles around. Co-authored-by: David Hu <davidhu314@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Discord, this PR changes the way we reset
box-sizingin our base/preflight styles.Context
Previously we were setting it on
<html>and letting everyone else inherit from there. Sadly, this approach doesn't take into account elements dependent on the shadow-dom.Since we don't have control over those elements, we can only do one of this:
box-sizingfor every element and pseudo-element<div>inside<details>Second approach would make this change safer but require us to keep adding things to our reset as users encounter new issues with other existing or future elements. PR implements the first option as it was also the one chosen at cssremedy.
Hopefully nothing breaks because of this change 馃