Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Oxide] Add built-in @import processing support #11239

Merged
merged 8 commits into from
May 15, 2023
Merged

[Oxide] Add built-in @import processing support #11239

merged 8 commits into from
May 15, 2023

Commits on May 15, 2023

  1. run PostCSS relative to test file 

    The PostCSS `from` was always set to the `tests/util/run` file with the
current test name as a query param to make it unique. However, that
results in issues with relative file paths because they are now relative
to this file instead of the actual test file.

Luckily, `expect.getState()` exposes the `testPath` value that points to
the current test file itself.
    @RobinMalfait
    RobinMalfait committed May 15, 2023
    Configuration menu
    Copy the full SHA
    6dec09c View commit details
    Browse the repository at this point in the history

  2. add built in @import processing 

    + additional features such that you can use `@tailwind` and `@config`
  directives before the `@import` at rule which isn't normally allowed.
  However "@tailwind" in a way is an `@import` and `@config` in a way is
  a `@charset` which can be used before the `@import` at rule.
    @RobinMalfait
    RobinMalfait committed May 15, 2023
    Configuration menu
    Copy the full SHA
    52bf44c View commit details
    Browse the repository at this point in the history

  3. drop partial normalizeTailwindDirectives when in the Oxide engine 

    This will now be handled by Tailwind from a higher level, so the core
doesn't have to worry about normalizing this anymore since it will
always be normalized right now.
    @RobinMalfait
    RobinMalfait committed May 15, 2023
    Configuration menu
    Copy the full SHA
    a0ab935 View commit details
    Browse the repository at this point in the history

  4. add handleImportAtRules to CLI

    @RobinMalfait
    RobinMalfait committed May 15, 2023
    Configuration menu
    Copy the full SHA
    98ee519 View commit details
    Browse the repository at this point in the history

  5. update changelog

    @RobinMalfait
    RobinMalfait committed May 15, 2023
    Configuration menu
    Copy the full SHA
    0a641dd View commit details
    Browse the repository at this point in the history

  6. scope import processing to the oxide engine

    @RobinMalfait
    RobinMalfait committed May 15, 2023
    Configuration menu
    Copy the full SHA
    1dcd968 View commit details
    Browse the repository at this point in the history

  7. update Changelog

    @RobinMalfait
    RobinMalfait committed May 15, 2023
    Configuration menu
    Copy the full SHA
    18905c9 View commit details
    Browse the repository at this point in the history

  8. use direct comparison 

    We don't need the `startsWith` check anymore because the contents of the
comment will be the actual value we expect.
    @RobinMalfait
    RobinMalfait committed May 15, 2023
    Configuration menu
    Copy the full SHA
    f7c4ffb View commit details
    Browse the repository at this point in the history