-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort classes using position of first matching rule #11504
Merged
thecrypticace
merged 5 commits into
master
from
fix/sorting-with-multiple-matching-rules
Jun 29, 2023
Merged
Sort classes using position of first matching rule #11504
thecrypticace
merged 5 commits into
master
from
fix/sorting-with-multiple-matching-rules
Jun 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This primarily affects components and utilities which contain multiple matched classes
thecrypticace
added a commit
that referenced
this pull request
Jul 13, 2023
* Refactor * Sort based on first occurence of a candidate This primarily affects components and utilities which contain multiple matched classes * Simplify * Update changelog * Update
thecrypticace
added a commit
that referenced
this pull request
Jul 13, 2023
* Refactor * Sort based on first occurence of a candidate This primarily affects components and utilities which contain multiple matched classes * Simplify * Update changelog * Update
thecrypticace
added a commit
that referenced
this pull request
Jul 13, 2023
* Refactor * Sort based on first occurence of a candidate This primarily affects components and utilities which contain multiple matched classes * Simplify * Update changelog * Update
This was referenced May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tailwindlabs/prettier-plugin-tailwindcss#174
Given a list of components like this:
Note that the last rule matches both the utilities
foo
andbar
.When sorting lists of classes we would iterate over all generated rules. Given that last rule matches both
foo
andbar
it would win for any instance offoo
used. This means that the utilityfoo
would have a much "later" position than expected. For example,foo-1 foo
would be sorted and stay as-is instead of becoming the expectedfoo foo-1
.Now, given that we cache rules, the internal utility we used to match against them could be overwritten. As such, once you used
bar
the utility was permanently changed and no longer matched the utilityfoo
causing the sort order to change for any list of classes after the one that used the utilitybar
.All that to say, given this HTML:
We would see the following HTML file as having sorted classes:
When in reality it should be this: