Added border x and y #1159
Closed
Added border x and y #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related #182 |
|
My bad, didn't know that there was already an issue for. |
|
No problem. Just leaving the link here so Adam doesn't have to go through everything when he sees this 👍 |
|
Hey thanks @DavydeVries! As has been mentioned we've discussed this a bit before and decided not to include it, so going to stick with that decision for now. Always can re-open the conversation down the road if there's enough demand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a little strange that there are classes like
px-andpy-.But not
border-xandborder-y. This pull request adds this. I think this makes tailwind consistent.I followed the contribution guide, but when I run
npm testthe test fails on thesanity.test.json the compare with the output file. I'm not sure how to re-render this/how to let this test pass.I tested this manually by copying
/dist/tailwind.cssto my own project and used classes likeborder-x,border-y,border-x-8, etc.Edit:
After some digging through discord, I found that you have to add the differences manually in output and output important. (maybe add this to the contribution docs)