Make content optional for presets in TypeScript types
#11730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of `Partial<Array<Thing>>` have `Array<Partial<Thing>>`
RobinMalfait
changed the title
content optional for presets in TypeScript types
|
Hey, thanks so much for this contribution! 🙏 I made a few small adjustments, but these types make more sense now, thanks! |
thecrypticace
pushed a commit
that referenced
this pull request
Oct 23, 2023
* Update config.d.ts, Make array members partial in Config Instead of `Partial<Array<Thing>>` have `Array<Partial<Thing>>` * simplify types further * update changelog --------- Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
This was referenced May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
Partial<Array<Thing>>haveArray<Partial<Thing>>Fixes: #11725
Also applies the same fix to safelist and blocklist properties of Config type.