Disable tap highlights on iOS #12299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
feat/no-tap-highlight
branch
from
9f66591
to
512ff76
Compare
zepfietje
reviewed
Oct 30, 2023
thecrypticace
added a commit
that referenced
this pull request
Dec 4, 2023
* Disable tap highlights on iOS * Update changelog * Update snapshots * Update changelog
thecrypticace
added a commit
that referenced
this pull request
Dec 5, 2023
* Disable tap highlights on iOS * Update changelog * Update snapshots * Update changelog
thecrypticace
added a commit
that referenced
this pull request
Dec 18, 2023
* Disable tap highlights on iOS * Update changelog * Update snapshots * Update changelog
|
This also applies to Android, right? |
|
It does (at least in Chrome) |
18 tasks
|
Why is this added? That tap highlight is an accessibility/UX thing. This means by default all websites built with TailwindCSS are now less accessible! @adamwathan, what changed? #9050 (comment) |
|
I hate this, i wondered why it got removed in my website and then i found this pr ... |
|
I agree with the above comments. Tap highlights being removed by default is an accessibility issue. |
|
I agree that this makes tailwind less accessible by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we're adding
-webkit-tap-highlight-color: transparent;to disable tap highlights on iOS.This means that the brief gray overlay that appears when tapping links or buttons will not anymore.
Before
with.highlight.mov
After
without.highlight.mov
If you want to re-enable the tap highlight in your own project you can do so by adding a rule to revert it to the original value: