Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spacing scale to min-width, min-height, and max-width #12300

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

thecrypticace
Copy link
Contributor

Our w-*, h-*, and max-h-* utilities all include our spacing scale which has various values across the range of 0–96 (from 0rem up to 24rem). However, our utilities for min-w-*, min-h-*, and max-w-* did not include these values. This leads to an inconsistent experience when using these utilities and this PR aims to fix those.

Now you can write utilities like min-w-32,min-h-3, or max-w-48 and get the following as you would expect:

.min-h-3 {
  min-height: 0.75rem;
}
.min-w-32 {
  min-width: 8rem;
}
.max-w-48 {
  max-width: 12rem;
}

@thecrypticace thecrypticace merged commit 782c733 into master Oct 26, 2023
10 checks passed
@thecrypticace thecrypticace deleted the feat/minmax-spacing branch October 26, 2023 18:14
thecrypticace added a commit that referenced this pull request Dec 4, 2023
* Add spacing scale to `min-width`, `min-height`, and `max-width`

* Update snapshots

* Update changelog
thecrypticace added a commit that referenced this pull request Dec 5, 2023
* Add spacing scale to `min-width`, `min-height`, and `max-width`

* Update snapshots

* Update changelog
thecrypticace added a commit that referenced this pull request Dec 18, 2023
* Add spacing scale to `min-width`, `min-height`, and `max-width`

* Update snapshots

* Update changelog
babakfp added a commit to babakfp/tailwindcss-addons that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant