Don't crash when given applying a variant to a negated version of a simple utility #12514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
fix/negative-utility-plus-variant-crash
branch
from
cc3d9dc
to
9e48c1e
Compare
thecrypticace
force-pushed
the
fix/negative-utility-plus-variant-crash
branch
from
4f50bb2
to
5e4cb47
Compare
thecrypticace
added a commit
that referenced
this pull request
Dec 1, 2023
…imple utility (#12514) * Don't crash when given applying a variant to a negated version of a simple utility * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a simple utility like the following:
If we encountered
hover:-top-lgwe didn't handle candidate elimination properly and anundefinedutility snuck in causing a crash. We now handle this appropriately and emit no CSS. We still emit CSS for.top-lgwhen we process-top-lgby itself but that's technically a separate bug that can be addressed later.Fixes #12435