Fix support for container query utilities with arbitrary values #12534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
fix/container-with-arbitrary-and-modifier
branch
from
5b2c531
to
5725f6c
Compare
thecrypticace
added a commit
that referenced
this pull request
Dec 5, 2023
* Fix support for container query utilities with arbitrary values * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, with our container queries plugin, you couldn't write
@container-[size]or@container-[size]/sidebareven though both should work. This was happening because we weren't picking either up as a utility. We were detectingcontainer-[size]andcontainer-[size]/sidebarwithout the leading@. This PR fixes our detection regex to pick up these utilities which will allow the container queries plugin to support these too.