Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move forced-colors variant after dark variant #12582

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Move forced-colors variant after dark variant #12582

merged 1 commit into from
Dec 13, 2023

Conversation

lukewarlow
Copy link
Contributor

Also add test for the order of the forced-colors variant

See #11694 (comment) for @devongovett's comment explaining the issue.

This would make forced-colors not match others such as contrast which should also arguably come after dark?

Just making this so it's here if you want.

@lukewarlow
Move forced-colors variant after dark variant
4771ddd 
Also add test for the order of the forced-colors variant
@lukewarlow lukewarlow mentioned this pull request Dec 12, 2023
Merged
@lukewarlow lukewarlow marked this pull request as ready for review December 12, 2023 22:58
@adamwathan
Copy link
Member

Thank you sir!

@adamwathan adamwathan merged commit fb85c8f into tailwindlabs:master Dec 13, 2023
10 checks passed
thecrypticace pushed a commit that referenced this pull request Dec 13, 2023
@lukewarlow @thecrypticace
Move forced-colors variant after dark variant (#12582)
4e67582 
Also add test for the order of the forced-colors variant
@lukewarlow lukewarlow deleted the forced-colors-order branch December 13, 2023 16:36
thecrypticace pushed a commit that referenced this pull request Dec 18, 2023
@lukewarlow @thecrypticace
Move forced-colors variant after dark variant (#12582)
e5b3a4d 
Also add test for the order of the forced-colors variant
thecrypticace pushed a commit that referenced this pull request Dec 18, 2023
@lukewarlow @thecrypticace
Move forced-colors variant after dark variant (#12582)
11a6ba3 
Also add test for the order of the forced-colors variant
@dcastil dcastil mentioned this pull request Dec 21, 2023
Merged
18 tasks
This was referenced May 19, 2024
Merged
Merged
@snyk-io snyk-io bot mentioned this pull request May 21, 2024
Open
@leroyanders leroyanders mentioned this pull request May 24, 2024
Open
@gptkrsh gptkrsh mentioned this pull request May 25, 2024
Open
@OKEAMAH OKEAMAH mentioned this pull request May 26, 2024
Open
@JCriz01 JCriz01 mentioned this pull request Jun 2, 2024
Open
@thavabalan thavabalan mentioned this pull request Jun 4, 2024
Open
@JCriz01 JCriz01 mentioned this pull request Jun 6, 2024
Open
@JCriz01 JCriz01 mentioned this pull request Jun 17, 2024
Open
This was referenced Jun 20, 2024
Open
Open
@TheAlpha16 TheAlpha16 mentioned this pull request Jun 21, 2024
Merged
@alejandrosuarez alejandrosuarez mentioned this pull request Jun 27, 2024
Open
@drobinso drobinso mentioned this pull request Jun 27, 2024
Open
@JCriz01 JCriz01 mentioned this pull request Jun 27, 2024
Open
@ariton1 ariton1 mentioned this pull request Jun 27, 2024
Open
@ariton1 ariton1 mentioned this pull request Jul 13, 2024
Open
@kalbroni7 kalbroni7 mentioned this pull request Jul 14, 2024
Open
@WontonSam WontonSam mentioned this pull request Jul 16, 2024
Open
@neutron-robot neutron-robot mentioned this pull request Jul 17, 2024
Open
@caniszczyk caniszczyk mentioned this pull request Jul 17, 2024
Open
@zubairbaig212 zubairbaig212 mentioned this pull request Jul 17, 2024
Open
This was referenced Jul 18, 2024
Open
Open
@leroyanders leroyanders mentioned this pull request Jul 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukewarlow @adamwathan