Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ellipsis and no-ellipsis utilities #1289

Closed
wants to merge 2 commits into from
Closed

Add ellipsis and no-ellipsis utilities #1289

wants to merge 2 commits into from

Conversation

benface
Copy link
Contributor

@benface benface commented Dec 29, 2019

Resolves #377

@adamwathan
Copy link
Member

adamwathan commented Feb 1, 2020

I think this is probably good, my only hesitation is around whether or not we should be future proofing to support text-overflow: <string> or text-overflow: fade. Any thoughts?

@pnadon
Copy link

pnadon commented Feb 2, 2020

I am also interested in this issue, I find that I need to truncate long segments of text, which should still fill their container and not just truncate at the end of the first line.

@benface
Copy link
Contributor Author

benface commented Feb 3, 2020

@adamwathan Yeah, I don't know. I was under the impression that those would not be available in browsers anytime soon, but I could be wrong. I can change this PR to use the utility names text-overflow-ellipsis and text-overflow-clip if you prefer that.

@pnadon text-overflow only truncates text on a per-line basis. I think you are looking for line-clamp; someone else made a feature request here: #1303

@adamwathan
Copy link
Member

adamwathan commented Oct 12, 2020

@benface Finally coming back to this, what about overflow-ellipsis and overflow-clip? Collides with the regular overflow utilities a bit but whatever, people write text-sm text-black and don't complain about it.

@adamwathan
Copy link
Member

adamwathan commented Oct 14, 2020

Merged this manually on the command line, thanks!

@adamwathan adamwathan closed this Oct 14, 2020
@benface
Copy link
Contributor Author

benface commented Oct 14, 2020

Oh hey thanks @adamwathan and sorry for not replying to your earlier comment! I was gonna update my PR (I totally agree with overflow-ellipsis and overflow-clip) but I'm having a busy week...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants