Sort arbitrary properties alphabetically across multiple class lists #12911
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tailwindlabs/prettier-plugin-tailwindcss#246
In Tailwind we sort classes alphabetically before processing to produce a deterministic order. And, when we encounter an arbitrary property we register it at that time so that's the order it'll take when sorting. In most cases this is fine because we sort up front, however, in the Prettier plugin we don't know all classes up front — each individual class list is sorted separately but uses the same internal context for performance reasons. This means that we need to do some extra bookkeeping to ensure they're sorted consistently regardless of the order of individual class lists or files scanned.
This PR does this bookkeeping and will sort classes to ensure that the arbitrary properties are always alphabetical when handled by the prettier plugin even scross separate class lists or files.
Now given these two files, a.jsx and b.jsx:
If you format each individual one with prettier or format all of them at one time the order of the properties will no longer flip-flop between these two lists: