Cleanup oxide — Part #2 #13312
Merged
Cleanup oxide — Part #2 #13312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
fix/cleanup-oxide-part-2
branch
from
8b51c0d
to
8563dd5
Compare
RobinMalfait
force-pushed
the
fix/cleanup-oxide-part-2
branch
from
8563dd5
to
7d724f6
Compare
thecrypticace
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #13304 but this time this strips out everything related to
stable,oxide,engineandcrosscheck.All the
stable.testorstable.expectis just replaced withtestandexpectrespectively. Everything related tooxideis dropped. Everything related toenv.ENGINEis also removed.Technically, in this version we don't have to use Lightning CSS anymore (it's only used in tests). However, all tests currently use a
toMatchFormattedCsswhich is not a snapshot so updating this would involve updating 268 tests manually.Because the wrapping
crosscheckis gone, it means that a lot of tests show big differences but those are mostly whitespace related. If you use the?w=1option, it should be a more digestible diff.