Add sensible set of fixed line-height utilities #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a set of fixed (not relative) line-height utilities to Tailwind by default:
These are very useful when you need fine-grained control over an element's size and the relative line-height utilities (like
leading-normal) give you weird height values that are hard to work with.A place where I ran into this myself recently is when sizing text fields with
text-smapplied. A 1.5 line-height results in a text block size of 21px which just makes life hard in so many ways when trying to align things precisely.I wrote about it in more detail in a recent Tailwind UI update email in case anyone wants the story: https://ckarchive.com/b/d0ueh0h8kl82