Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dark mode by default, rename config option to darkMode #2631

Merged
merged 2 commits into from Oct 21, 2020

Conversation

adamwathan
Copy link
Member

@adamwathan adamwathan commented Oct 21, 2020

This PR disables dark mode by default because of the affect it has on the default build size. The config stubs include darkMode: false by default though which can easily be changed to 'media' if the user wants dark mode variants enabled.

I've also changed the name of the config option from simply dark to darkMode because I think it's a bit clearer. Minor breaking change for anyone using the experimental version but 500ms to update.

@adamwathan adamwathan merged commit b92f033 into master Oct 21, 2020
2 checks passed
@adamwathan adamwathan deleted the disable-dark-mode branch Oct 21, 2020
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant