Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use left/right instead of inline-start/end for space/divide utilities #2644

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Use left/right instead of inline-start/end for space/divide utilities #2644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,728 changes: 864 additions & 864 deletions __tests__/fixtures/tailwind-output-flagged.css
View file
Open in desktop

Large diffs are not rendered by default.

1,728 changes: 864 additions & 864 deletions __tests__/fixtures/tailwind-output-important.css
View file
Open in desktop

Large diffs are not rendered by default.

1,728 changes: 864 additions & 864 deletions __tests__/fixtures/tailwind-output-no-color-opacity.css
View file
Open in desktop

Large diffs are not rendered by default.

1,728 changes: 864 additions & 864 deletions __tests__/fixtures/tailwind-output.css
View file
Open in desktop

Large diffs are not rendered by default.

16 changes: 8 additions & 8 deletions __tests__/plugins/divideWidth.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ test('generating divide width utilities', () => {
},
'.divide-x > :not([hidden]) ~ :not([hidden])': {
'--divide-x-reverse': '0',
'border-inline-end-width': 'calc(1px * var(--divide-x-reverse))',
'border-inline-start-width': 'calc(1px * calc(1 - var(--divide-x-reverse)))',
'border-right-width': 'calc(1px * var(--divide-x-reverse))',
'border-left-width': 'calc(1px * calc(1 - var(--divide-x-reverse)))',
},
'.divide-y-0 > :not([hidden]) ~ :not([hidden])': {
'--divide-y-reverse': '0',
Expand All @@ -38,8 +38,8 @@ test('generating divide width utilities', () => {
},
'.divide-x-0 > :not([hidden]) ~ :not([hidden])': {
'--divide-x-reverse': '0',
'border-inline-end-width': 'calc(0px * var(--divide-x-reverse))',
'border-inline-start-width': 'calc(0px * calc(1 - var(--divide-x-reverse)))',
'border-right-width': 'calc(0px * var(--divide-x-reverse))',
'border-left-width': 'calc(0px * calc(1 - var(--divide-x-reverse)))',
},
'.divide-y-2 > :not([hidden]) ~ :not([hidden])': {
'--divide-y-reverse': '0',
Expand All @@ -48,8 +48,8 @@ test('generating divide width utilities', () => {
},
'.divide-x-2 > :not([hidden]) ~ :not([hidden])': {
'--divide-x-reverse': '0',
'border-inline-end-width': 'calc(2px * var(--divide-x-reverse))',
'border-inline-start-width': 'calc(2px * calc(1 - var(--divide-x-reverse)))',
'border-right-width': 'calc(2px * var(--divide-x-reverse))',
'border-left-width': 'calc(2px * calc(1 - var(--divide-x-reverse)))',
},
'.divide-y-4 > :not([hidden]) ~ :not([hidden])': {
'--divide-y-reverse': '0',
Expand All @@ -58,8 +58,8 @@ test('generating divide width utilities', () => {
},
'.divide-x-4 > :not([hidden]) ~ :not([hidden])': {
'--divide-x-reverse': '0',
'border-inline-end-width': 'calc(4px * var(--divide-x-reverse))',
'border-inline-start-width': 'calc(4px * calc(1 - var(--divide-x-reverse)))',
'border-right-width': 'calc(4px * var(--divide-x-reverse))',
'border-left-width': 'calc(4px * calc(1 - var(--divide-x-reverse)))',
},
'.divide-y-reverse > :not([hidden]) ~ :not([hidden])': {
'--divide-y-reverse': '1',
Expand Down
24 changes: 12 additions & 12 deletions __tests__/plugins/space.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ test('generating space utilities', () => {
},
'.space-x-0 > :not([hidden]) ~ :not([hidden])': {
'--space-x-reverse': '0',
'margin-inline-end': 'calc(0px * var(--space-x-reverse))',
'margin-inline-start': 'calc(0px * calc(1 - var(--space-x-reverse)))',
'margin-right': 'calc(0px * var(--space-x-reverse))',
'margin-left': 'calc(0px * calc(1 - var(--space-x-reverse)))',
},
'.space-y-1 > :not([hidden]) ~ :not([hidden])': {
'--space-y-reverse': '0',
Expand All @@ -40,8 +40,8 @@ test('generating space utilities', () => {
},
'.space-x-1 > :not([hidden]) ~ :not([hidden])': {
'--space-x-reverse': '0',
'margin-inline-end': 'calc(1px * var(--space-x-reverse))',
'margin-inline-start': 'calc(1px * calc(1 - var(--space-x-reverse)))',
'margin-right': 'calc(1px * var(--space-x-reverse))',
'margin-left': 'calc(1px * calc(1 - var(--space-x-reverse)))',
},
'.space-y-2 > :not([hidden]) ~ :not([hidden])': {
'--space-y-reverse': '0',
Expand All @@ -50,8 +50,8 @@ test('generating space utilities', () => {
},
'.space-x-2 > :not([hidden]) ~ :not([hidden])': {
'--space-x-reverse': '0',
'margin-inline-end': 'calc(2px * var(--space-x-reverse))',
'margin-inline-start': 'calc(2px * calc(1 - var(--space-x-reverse)))',
'margin-right': 'calc(2px * var(--space-x-reverse))',
'margin-left': 'calc(2px * calc(1 - var(--space-x-reverse)))',
},
'.space-y-4 > :not([hidden]) ~ :not([hidden])': {
'--space-y-reverse': '0',
Expand All @@ -60,8 +60,8 @@ test('generating space utilities', () => {
},
'.space-x-4 > :not([hidden]) ~ :not([hidden])': {
'--space-x-reverse': '0',
'margin-inline-end': 'calc(4px * var(--space-x-reverse))',
'margin-inline-start': 'calc(4px * calc(1 - var(--space-x-reverse)))',
'margin-right': 'calc(4px * var(--space-x-reverse))',
'margin-left': 'calc(4px * calc(1 - var(--space-x-reverse)))',
},
'.-space-y-2 > :not([hidden]) ~ :not([hidden])': {
'--space-y-reverse': '0',
Expand All @@ -70,8 +70,8 @@ test('generating space utilities', () => {
},
'.-space-x-2 > :not([hidden]) ~ :not([hidden])': {
'--space-x-reverse': '0',
'margin-inline-end': 'calc(-2px * var(--space-x-reverse))',
'margin-inline-start': 'calc(-2px * calc(1 - var(--space-x-reverse)))',
'margin-right': 'calc(-2px * var(--space-x-reverse))',
'margin-left': 'calc(-2px * calc(1 - var(--space-x-reverse)))',
},
'.-space-y-1 > :not([hidden]) ~ :not([hidden])': {
'--space-y-reverse': '0',
Expand All @@ -80,8 +80,8 @@ test('generating space utilities', () => {
},
'.-space-x-1 > :not([hidden]) ~ :not([hidden])': {
'--space-x-reverse': '0',
'margin-inline-end': 'calc(-1px * var(--space-x-reverse))',
'margin-inline-start': 'calc(-1px * calc(1 - var(--space-x-reverse)))',
'margin-right': 'calc(-1px * var(--space-x-reverse))',
'margin-left': 'calc(-1px * calc(1 - var(--space-x-reverse)))',
},
'.space-y-reverse > :not([hidden]) ~ :not([hidden])': {
'--space-y-reverse': '1',
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/divideWidth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ export default function () {
},
[`${nameClass('divide-x', modifier)} > :not([hidden]) ~ :not([hidden])`]: {
'--divide-x-reverse': '0',
'border-inline-end-width': `calc(${size} * var(--divide-x-reverse))`,
'border-inline-start-width': `calc(${size} * calc(1 - var(--divide-x-reverse)))`,
'border-right-width': `calc(${size} * var(--divide-x-reverse))`,
'border-left-width': `calc(${size} * calc(1 - var(--divide-x-reverse)))`,
},
}
},
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/space.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ export default function () {
},
[`${nameClass('space-x', modifier)} > :not([hidden]) ~ :not([hidden])`]: {
'--space-x-reverse': '0',
'margin-inline-end': `calc(${size} * var(--space-x-reverse))`,
'margin-inline-start': `calc(${size} * calc(1 - var(--space-x-reverse)))`,
'margin-right': `calc(${size} * var(--space-x-reverse))`,
'margin-left': `calc(${size} * calc(1 - var(--space-x-reverse)))`,
},
}
},
Expand Down