Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ring defaults #2951

Merged
merged 3 commits into from Dec 2, 2020
Merged

ring defaults #2951

merged 3 commits into from Dec 2, 2020

Conversation

RobinMalfait
Copy link
Contributor

@RobinMalfait RobinMalfait commented Nov 30, 2020

Resolves #2911.

This PR allows you to set default values for the ring utilities, you can define the default offset width and offset color.

module.exports = {
  theme: {
    extend: {
      ringOffsetColor: {
        black: 'black',
        DEFAULT: 'black',
      },
      ringOffsetWidth: {
       4: '4px',
        DEFAULT: '4px'
      }
    },
  },
  variants: {},
  plugins: [],
}

This will allow you to write ring-2 instead of ring-2 ring-offset-black ring-offset-4

@RobinMalfait RobinMalfait requested a review from adamwathan Nov 30, 2020
@florianbouvot
Copy link

florianbouvot commented Nov 30, 2020

Thanks @RobinMalfait

@adamwathan adamwathan merged commit d1ef88a into master Dec 2, 2020
2 checks passed
@adamwathan adamwathan deleted the ring-defaults branch Dec 2, 2020
@rightaway
Copy link

rightaway commented Jan 4, 2021

@RobinMalfait Docs includes DEFAULT info under Ring Width, but not under Ring Offset Width so it isn't clear from reading that it's possible for Offset too.

This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants