Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Unify JIT and AOT code paths #4188

Merged
merged 13 commits into from Apr 30, 2021
Merged

[WIP] Unify JIT and AOT code paths #4188

merged 13 commits into from Apr 30, 2021

Conversation

@RobinMalfait
Copy link
Contributor

@RobinMalfait RobinMalfait commented Apr 26, 2021

WIP start by unifying JIT and AOT codepaths.

@adamwathan adamwathan changed the title cleanup codepaths [WIP] Unify JIT and AOT code paths Apr 26, 2021
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Apr 28, 2021

Codecov Report

Merging #4188 (9556a02) into master (9b1e843) will increase coverage by 0.02%.
The diff coverage is 81.89%.

Current head 9556a02 differs from pull request most recent head 226dbc4. Consider uploading reports for the commit 226dbc4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4188      +/-   ##
==========================================
+ Coverage   86.84%   86.87%   +0.02%     
==========================================
  Files         341      217     -124     
  Lines        4836     5036     +200     
  Branches      919     1019     +100     
==========================================
+ Hits         4200     4375     +175     
- Misses        561      601      +40     
+ Partials       75       60      -15     
Impacted Files Coverage Δ
src/plugins/inset.js 66.66% <61.97%> (-33.34%) ⬇️
jit/corePlugins/index.js 90.32% <66.66%> (ø)
src/plugins/fill.js 84.84% <75.00%> (-15.16%) ⬇️
src/plugins/fontSize.js 75.47% <75.00%> (-24.53%) ⬇️
src/plugins/stroke.js 84.84% <75.00%> (-15.16%) ⬇️
src/plugins/gradientColorStops.js 78.94% <76.47%> (-21.06%) ⬇️
src/plugins/divideWidth.js 80.00% <76.92%> (-20.00%) ⬇️
src/plugins/transitionProperty.js 83.33% <78.57%> (-16.67%) ⬇️
src/plugins/boxShadow.js 81.08% <78.78%> (-18.92%) ⬇️
src/plugins/divideOpacity.js 81.48% <80.00%> (-18.52%) ⬇️
... and 155 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b1e843...226dbc4. Read the comment docs.

@adamwathan adamwathan force-pushed the cleanup-codepaths branch from 63522aa to 33df925 Apr 30, 2021
@adamwathan adamwathan merged commit bfc6162 into master Apr 30, 2021
2 checks passed
@adamwathan adamwathan deleted the cleanup-codepaths branch Apr 30, 2021
adamwathan added a commit that referenced this issue May 7, 2021
* WIP

* WIP

* Finish combining JIT and AOT plugins

Still lots of clean up that can be done in some of the more complex ones, but at least it's one file per plugin now.

* Remove unused import

* Fix AOT generation bugs

* Move corePlugins/index.js to corePlugins.js

* Convert JIT files to ESM

* Move tests

* Reorder core plugins to match JIT order

* Update AOT apply tests

* Unify utils

* Combine plugin lists to one single source of truth

* Finish resolving merge conflicts, fix tests

Co-authored-by: Adam Wathan <adam.wathan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants