Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on postcss-functions #4317

Merged
merged 3 commits into from May 11, 2021
Merged

Conversation

@adamwathan
Copy link
Contributor

@adamwathan adamwathan commented May 11, 2021

This PR removes our dependency on postcss-functions by implementing the logic we need ourselves. The primary motivation for this is to be able to throw errors from the relevant node, instead of having to throw them from the root. Using postcss-functions we had no way to access the actual node where the function was being called to throw a helpful error, but by implementing it ourselves we can make sure to keep a reference to the node and make it available to the actual function.

@adamwathan adamwathan force-pushed the inline-postcss-functions branch 4 times, most recently from 72634f9 to b2ac4ed May 11, 2021
@adamwathan adamwathan force-pushed the inline-postcss-functions branch from b2ac4ed to 94cca19 May 11, 2021
@adamwathan adamwathan merged commit 5ebe5e8 into master May 11, 2021
3 checks passed
3 checks passed
@github-actions
build (12)
Details
@github-actions
build (14)
Details
@github-actions
build (16)
Details
@adamwathan adamwathan deleted the inline-postcss-functions branch May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant