Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure resorted plugins take into account all plugins they need to sort relative to #4852

Merged
merged 1 commit into from Jul 1, 2021

Conversation

adamwathan
Copy link
Member

@adamwathan adamwathan commented Jul 1, 2021

Fixes #4849.

This PR ensures that when we mutate the original plugin order (since JIT and AOT need slightly different plugin orders) that we take into account all plugins a resorted plugin needs to be moved relative to to ensure that the sort order is correct even if plugins are disabled.

@adamwathan adamwathan merged commit 369c7b5 into master Jul 1, 2021
3 checks passed
@adamwathan adamwathan deleted the fix-4849 branch Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant