Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow default ring color to be a function #7587

merged 2 commits into from Feb 22, 2022


Copy link

Fixes #6748

We were resolving ringColor.DEFAULT directly in theme instead of ringColor and then pulling the DEFAULT key from it. The difference here is that when calling theme() it'll call the function w/o arguments. In this case we want withAlphaValue to call the function with the appropriate opacityValue even when setting the default.

@thecrypticace thecrypticace merged commit d72b277 into master Feb 22, 2022
@thecrypticace thecrypticace deleted the fix/default-ring-color-fn branch February 22, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Default colour not applied to ring when using function to generate it
1 participant