Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add future flag to preserve custom, default ring color opacity #8448

Merged
merged 3 commits into from May 27, 2022

Conversation

thecrypticace
Copy link
Collaborator

@thecrypticace thecrypticace commented May 26, 2022

Currently we apply the default ring opacity to any custom, default ring color even when it has an opacity specified explicitly. This default opacity is only used by the default ring color making the behavior even more confusing. Since this is not the most expected behavior we'll be changing this. Given that it's a backwards incompatible change we cannot do so until v4 (whenever that happens in the future).

To ease future migration we'll allow users to opt-in to this change earlier by using the new feature flag future.respectDefaultRingColorOpacity which preserves the default ring color the user specifies effectively as is.

Fixes #7800

@thecrypticace thecrypticace merged commit cab1fce into master May 27, 2022
@thecrypticace thecrypticace deleted the feature/preserve-ring-color-flag branch May 27, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default ringColor has opacity baked into it
1 participant