Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Only listen for stdin close on TTYs (#8523)" #9331

merged 2 commits into from Sep 14, 2022


Copy link

This reverts commit 14f6574.

This was originally done to fix issues with Turborepo but it had some unforeseen side effects that would leave dangling processes. For things that use Erlang (for example Phoenix) this is a problem because Erlang does not have the necessary APIs to send signals to processes — instead relying only on stdin closing behavior or wrapper scripts to work around this.

As a bonus it seems that Turborepo has updated their official tailwind example to use concurrently which sidesteps this problem entirely because it acts as the wrapper in this case and handles stdin for child processes appropriately.

Fixes #9264

@thecrypticace thecrypticace merged commit 4e62334 into master Sep 14, 2022
@thecrypticace thecrypticace deleted the fix/stdin-listening branch September 14, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Dangling tailwind-cli process when using Phoenix Framework
1 participant