Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cannot read properties of undefined (reading 'modifier') #9656

Merged
merged 5 commits into from
Nov 3, 2022

Conversation

ttkoma
Copy link
Contributor

@ttkoma ttkoma commented Oct 25, 2022

Fixes: #9655

if (!args) {
return null
}

if (args.value === sharedState.NONE && !hasDefault) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (!args ||  args.value === sharedState.NONE && !hasDefault) {
return null;
}

@RobinMalfait RobinMalfait self-assigned this Nov 3, 2022
@RobinMalfait RobinMalfait changed the title fix #9655 Fix cannot read properties of undefined (reading 'modifier') Nov 3, 2022
@RobinMalfait
Copy link
Contributor

Hey! Thank you for your PR!
Much appreciated! 🙏

I've made a few small changes so that it behaves similar to how it behaved before we made those internal changes. Also added a test that verifies this behaviour (without crashing).

Thanks!

@RobinMalfait RobinMalfait merged commit bf28bf6 into tailwindlabs:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading 'modifier')
3 participants