Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure configured font-feature-settings are included in Preflight #9707

merged 3 commits into from
Nov 1, 2022


Copy link

@bradlc bradlc commented Nov 1, 2022

Fixes #9666

This PR adds font-feature-settings to preflight, with the value set to the user's configured settings for the sans font family. If font-feature-settings has not been configured for sans then the normal value is used, which is the default value for the font-feature-settings property.

@bradlc bradlc marked this pull request as ready for review November 1, 2022 17:18
@bradlc bradlc changed the title Add font-feature-settings to html in preflight Ensure configured font-feature-settings are included in Preflight Nov 1, 2022
@bradlc bradlc merged commit 7ec9dc3 into master Nov 1, 2022
@bradlc bradlc deleted the preflight-font-feature-settings branch November 1, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

The sans font family is incorrectly generated on the html rule when using fontFeatureSettings
1 participant