Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dig into Relay's param handling when new params are empty #1

Closed
taion opened this issue Sep 8, 2015 · 1 comment
Closed

Dig into Relay's param handling when new params are empty #1

taion opened this issue Sep 8, 2015 · 1 comment

Comments

@taion
Copy link
Owner

taion commented Sep 8, 2015

The workaround at

queryParams={['status']} // Inject the status param to trigger re-fetch.
is necessary to get react-router-relay to behave correctly during the loading transition, but even net of react-router-relay, Relay itself seems to return the result query with the old route parameters when I try to blank out the route parameters.

When I have a chance, I should dig into the Relay code and figure out what's going on, assuming it's not a bug in react-router-relay.

@taion
Copy link
Owner Author

taion commented Nov 26, 2015

Well, that workaround is gone, anyway, so this isn't really relevant any more.

@taion taion closed this as completed Nov 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant