Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Write Highlight Extension for Asciidoctor 2.0 #16

Open
1 task
tajmone opened this issue Oct 21, 2019 · 0 comments
Open
1 task

Re-Write Highlight Extension for Asciidoctor 2.0 #16

tajmone opened this issue Oct 21, 2019 · 0 comments
Labels
💡 enhancement A new feature or enhancement request 👑 HTML Issues with conversion to HTML format 🔨 Asciidoctor Tool: Asciidoctor 🔨 Highlight Tool: Highlight (syntax highlighter) 🔬 research Issue requires further researching ♻️ help wanted Collaborative help is needed ⭐ syntax highlighting Topic: Syntax Highlighting 👅 Ruby Lang: Ruby ⚠️ important Priority: High
Milestone

Comments

@tajmone
Copy link
Owner

tajmone commented Oct 21, 2019

Problem

The current Highlight TreeProcessor extension employed in this project to integrate Highlight into the Asciidoctor toolchain is based on very old code and has a number of limitations:

Solution

The problem here is that I dont' have enough knowledge of Ruby nor the Asciidoctor API to do it — I've tried many times over, without results (see: alan-if/alan-docs#36).

Any help from someone fluent in Ruby is appreciated.

Known Limitations

In order of severity:

  • Doesn't support callouts in code blocks.
  • Code blocks inside table cells is not highlighted.
  • Limited and buggy support for substitutions in code blocks via the subs attribute.
  • Risk of becoming unusable in the future, if the API 2.0 breaks support for legacy extensions.

Reference Links

Other issues were I discuss this topic:

@tajmone tajmone added 💡 enhancement A new feature or enhancement request ♻️ help wanted Collaborative help is needed ⚠️ important Priority: High ⭐ syntax highlighting Topic: Syntax Highlighting 👑 HTML Issues with conversion to HTML format 🔨 Asciidoctor Tool: Asciidoctor 🔨 Highlight Tool: Highlight (syntax highlighter) 🔬 research Issue requires further researching 👅 Ruby Lang: Ruby labels Oct 21, 2019
@tajmone tajmone added this to the Plus Ultra milestone Oct 21, 2019
@tajmone tajmone modified the milestones: plus ultra, hugo code Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 enhancement A new feature or enhancement request 👑 HTML Issues with conversion to HTML format 🔨 Asciidoctor Tool: Asciidoctor 🔨 Highlight Tool: Highlight (syntax highlighter) 🔬 research Issue requires further researching ♻️ help wanted Collaborative help is needed ⭐ syntax highlighting Topic: Syntax Highlighting 👅 Ruby Lang: Ruby ⚠️ important Priority: High
Projects
None yet
Development

No branches or pull requests

1 participant