Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

§9.2: Code Errors in Strings #38

Closed
4 tasks done
tajmone opened this issue Nov 24, 2019 · 1 comment
Closed
4 tasks done

§9.2: Code Errors in Strings #38

tajmone opened this issue Nov 24, 2019 · 1 comment
Assignees
Labels
🕐 add to changes Contents changes that need to be documented 💀 bug Something isn't working ⚠️ important Priority: High
Milestone

Comments

@tajmone
Copy link
Owner

tajmone commented Nov 24, 2019

  • Get @tessman approval for these changes.
  • Fix document source.
  • Document the changes in CHANGES.md.
  • Update commented annotation in source file.

In §9.2. What Should I Be Able to Do Now? there seems to be some problems with the following code:

case 1
    print CThe(player); \
        MatchPlural(player, "doesn't, "don't"); \
        need to use the word \""; \
        parse$; "\"."

looks like ther's a missing closing d-quote in "doesn't and a missing opening quote in need to use the word \""; \:

case 1
    print CThe(player); \
        MatchPlural(player, "doesn't", "don't"); \
        "need to use the word \""; \
        parse$; "\"."
@tajmone tajmone added 💀 bug Something isn't working ⚠️ important Priority: High 🕐 add to changes Contents changes that need to be documented 🕑 pending approval Issue requires approval by Ken Tessman labels Nov 24, 2019
@tajmone tajmone added this to the hugo code milestone Nov 24, 2019
@tajmone tajmone mentioned this issue Dec 22, 2019
38 tasks
@tessman
Copy link
Collaborator

tessman commented Dec 31, 2019

That seems to be exactly right. And there's a space missing before "need...

Here's the excerpt right out of hugolib.h:

		case 1
			print CThe(player); \
				! " can't use the word \""; \
				MatchPlural(player, "doesn't", "don't"); \
				" need to use the word \""; \
				parse$; "\"."

@tajmone tajmone closed this as completed Dec 31, 2019
@tajmone tajmone removed the 🕑 pending approval Issue requires approval by Ken Tessman label Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕐 add to changes Contents changes that need to be documented 💀 bug Something isn't working ⚠️ important Priority: High
Projects
None yet
Development

No branches or pull requests

2 participants