Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Master Release: Fix Live HTML Links #9

Closed
tajmone opened this issue Oct 20, 2019 · 1 comment
Closed

Master Release: Fix Live HTML Links #9

tajmone opened this issue Oct 20, 2019 · 1 comment
Labels
🕑 on 1st release To be done right before 1st release on master branch 🔨 GitHub Pages Tool: GitHub Pages project website
Projects
1st Release
Milestone
master checklist

Comments

@tajmone
Copy link
Owner

tajmone commented Oct 20, 2019

Before merging into master branch for the 1st book release, remember to update all Live HTML Preview links in the various MD documents, so they point to master branch instead of draft.
@tajmone tajmone added the 🕑 on 1st release To be done right before 1st release on master branch label Oct 20, 2019
@tajmone tajmone added this to the Master Branch Release milestone Oct 20, 2019
@tajmone tajmone added this to To do in 1st Release Oct 20, 2019
@tajmone tajmone mentioned this issue Dec 22, 2019
Closed
38 tasks
@tajmone
Copy link
Owner Author

tajmone commented Dec 22, 2019

GitHub Pages Pages Note

Since the book will also be available online through GitHub Pages repository websites, we might just as well link directly to the online book instead of having to go through the Live HTML Preview service.

But, of course, this will involve multiple steps first:

  • merge into master
  • enable the GitHub Pages project website.
  • update all preview links to point to the online document.

So, in the meantime it might still be worth keeping the Live HTML Preview links for the first commit on master branch, and then move to the second and third steps with further commits, and maybe after squash them and force push.

@tajmone tajmone added the 🔨 GitHub Pages Tool: GitHub Pages project website label Dec 23, 2019
@tajmone tajmone pinned this issue Jan 29, 2020
tajmone added a commit that referenced this issue Jan 30, 2020
@tajmone
Fix HTML Live Links
2abc468 
Replace all HTML preview links from pointing to htmlpreview.github.io
to pointing to the upcoming GitHub Pages website (see #44):

- https://tajmone.github.io/hugo-book/

(closes #9)
@tajmone tajmone closed this as completed Jan 30, 2020
1st Release automation moved this from To do to Done Jan 30, 2020
@tajmone tajmone unpinned this issue Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🕑 on 1st release To be done right before 1st release on master branch 🔨 GitHub Pages Tool: GitHub Pages project website
Projects
No open projects
1st Release
  
Done
Milestone
master checklist
Development

No branches or pull requests
1 participant
@tajmone