Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Reach components to support React 18 #114

Closed
tajo opened this issue Apr 28, 2022 · 1 comment
Closed

Update Reach components to support React 18 #114

tajo opened this issue Apr 28, 2022 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@tajo
Copy link
Owner

tajo commented Apr 28, 2022

While Ladle supports React 18, Reach Dialog (its dependency) needs to be update as well to satisfy more strict pnpm.

packages/my-package
└─┬ @ladle/react
  └─┬ @reach/dialog
    ├── ✕ unmet peer react@"^16.8.0 || 17.x": found 18.0.0
    ├── ✕ unmet peer react-dom@"^16.8.0 || 17.x": found 18.0.0
    ├─┬ @reach/portal
    │ ├── ✕ unmet peer react@"^16.8.0 || 17.x": found 18.0.0
    │ ├── ✕ unmet peer react-dom@"^16.8.0 || 17.x": found 18.0.0
    │ └─┬ @reach/utils
    │   ├── ✕ unmet peer react@"^16.8.0 || 17.x": found 18.0.0
    │   └── ✕ unmet peer react-dom@"^16.8.0 || 17.x": found 18.0.0
    └─┬ react-focus-lock
      └─┬ react-clientside-effect
        └── ✕ unmet peer react@"^15.3.0 || ^16.0.0 || ^17.0.0": found 18.0.0
@tajo tajo added enhancement New feature or request bug Something isn't working labels Apr 28, 2022
@tajo tajo mentioned this issue May 3, 2022
Merged
@tajo
Copy link
Owner Author

tajo commented May 3, 2022

Fixed with 0.15.0.

@tajo tajo closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tajo