Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Accessibility Report button with @ladle/react v3.1.0 and up #527

Closed
esbeto opened this issue Oct 18, 2023 · 2 comments
Closed

Missing Accessibility Report button with @ladle/react v3.1.0 and up #527

esbeto opened this issue Oct 18, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@esbeto
Copy link

esbeto commented Oct 18, 2023

Describe the bug

For some reason I lost the accessibility report and button when upgrading ladle, I tried different versions and the last one that works for me is 3.0.0

Reproduction

I was able to reproduce with Stackblitz.
Just change the dependency to:

    "@ladle/react": "3.0.0",

to see the accessibility report button.

Environment

  • OS: MacOS Ventura 13.6
  • Browser: Firefox 118 Chrome 118
  • (I wasn't aware both browsers are now in matching version numbers 😅)
@esbeto esbeto added the needs triage needs to be reviewed label Oct 18, 2023
@tajo
Copy link
Owner

tajo commented Oct 18, 2023

It's just disabled by default now. You can easily enable it again: https://ladle.dev/docs/a11y

axe-core is a pretty big dependency so we don't want to bundle it with Ladle unless it's actively used.

@tajo tajo added documentation Improvements or additions to documentation and removed needs triage needs to be reviewed labels Oct 18, 2023
@tajo tajo closed this as completed Oct 19, 2023
@esbeto
Copy link
Author

esbeto commented Oct 26, 2023

Thanks! I suggest to include changes in defaults in the release notes next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants