MechanismList MIC has incorrect type

[softworkz]

Hi,

first - thank you very much for publishing this interesting library.

I'm trying to use this library for client access using the code from issue #9.

I tried to connect to

• a Linux machine with Samba (Smb2Client)
• a Windows 2003 Server/PDC in a Domain (Smb1Client)
• a windows 2016 Server in another Domain (Smb2Client)

I'm always ending up here:

SMBLibrary/SMBLibrary/Authentication/GSSAPI/SPNEGO/SimpleProtectedNegotiationTokenInit.cs

Line 176 in 86afb5a

if (tag != (byte)DerEncodingTag.ByteArray)

In all cases, the tag is not DerEncodingTag.ByteArray but DerEncodingTag.Sequence instead.

I can't imagine an explanation for this. It's really weird that it happens in all 3 cases. These cases are different otherwise (different buffer length, different parsed mechanisms).

When I ignore the exception, all subsequent operations against the Samba machine are successful (but there's guest access enabled), but not for the Windows servers...

Any ideas?

[TalAloni]

Please try changing line 74 in SimpleProtectedNegotiationToken.cs from:

return new SimpleProtectedNegotiationTokenInit(tokenBytes, offset);

to

return new SimpleProtectedNegotiationTokenInit2(tokenBytes, offset);

[softworkz]

Thanks for the quick response.
That part is solved.

But right for the next step, I'm experiencing odd behavior again:

Smb1Client.Login always returns success, no matter if credentials are right or wrong.
Then I'm calling Smb1Client.ListShares()

• If credentials were incorrect, I get a list of shares
• If credentials were correct, ListShares returns ACCESS_DENIED
  (sic!)

Smb1Client.TreeConnect() always returns ACCESS_DENIED.

[TalAloni]

You're going to have to dig a little deeper,
Is the server returning 'STATUS_SUCCESS' when the credentials are incorrect? if so, this is an issue with the server.
Does the user have access to the share?
Try to check with a different client to verify if the issue is indeed with the SMBLibrary client. and if it is, try to find what (and where) the issue is exactly.

[TalAloni]

My latest commit should have fixed the original issue that you reported.
please test and let me know if there are any additional issues.
please open a separate issue for each issue you encounter.