Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Constructable Interface #25

Closed
taljacob2 opened this issue Jan 3, 2023 · 0 comments · Fixed by #43
Closed

Remove Constructable Interface #25

taljacob2 opened this issue Jan 3, 2023 · 0 comments · Fixed by #43
Assignees
@taljacob2
Labels
documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested

Comments

@taljacob2
Copy link
Owner

Because we didn't use the constructor of Constructable in any way during building the objects in the project, we may consider to delete the Constructable interface entirely from the project, and delete all the assignments to it in the constructors.

For example:

Redundant Code:
image

Redundant Code:
image
@taljacob2 taljacob2 added documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested labels Jan 3, 2023
@taljacob2 taljacob2 self-assigned this Jan 3, 2023
@taljacob2 taljacob2 linked a pull request Jan 10, 2023 that will close this issue
Issue 25 #43
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taljacob2 taljacob2

Labels
documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested
Projects
Master Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 25 taljacob2/oop
1 participant
@taljacob2