Skip to content

Commit

Permalink
Revert "#128: REVERTME show Toast and launch browser if unsupported c…
Browse files Browse the repository at this point in the history
…omments URL"

This reverts commit 4a3fdb3.
  • Loading branch information
talklittle committed Dec 30, 2011
1 parent 4a3fdb3 commit bfe3714
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 10 deletions.
2 changes: 0 additions & 2 deletions res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,6 @@
<string name="previous_threads">prev</string>

<string name="error_voting_toast">Error voting. Please try again.</string>
<string name="error_unsupported_link_toast">Unsupported reddit URL. Try opening in the web browser instead.</string>

<string name="mail_notification_unscheduled">Reddit mail notification service disabled.</string>
<string name="mail_notification_scheduled_5min">Reddit mail set to check every 5 minutes.</string>
<string name="mail_notification_scheduled_30min">Reddit mail set to check every 30 minutes.</string>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -237,16 +237,10 @@ protected void onCreate(Bundle savedInstanceState) {
mSubreddit = m.group(1);
mThreadId = m.group(2);
jumpToCommentId = m.group(3);
} else {
Log.i(TAG, "unparsable comment path: " + commentPath);
Toast.makeText(this, R.string.error_unsupported_link_toast, Toast.LENGTH_LONG).show();
Common.launchBrowser(this, data.toString(), null, false, true, true);
finish();
return;
}
}
} else {
if (Constants.LOGGING) Log.e(TAG, "Quitting because of null comment path.");
if (Constants.LOGGING) Log.e(TAG, "Quitting because of bad comment path.");
finish();
return;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
public class DownloadCommentsTask extends AsyncTask<Integer, Long, Boolean>
implements PropertyChangeListener {

private static final String TAG = "DownloadCommentsTask";
private static final String TAG = "CommentsListActivity.DownloadCommentsTask";

private final ObjectMapper mObjectMapper = Common.getObjectMapper();
private final Markdown markdown = new Markdown();
Expand Down

0 comments on commit bfe3714

Please sign in to comment.