Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest release doesn't contain precompiled binaries #542

Closed
kziemianek opened this issue Feb 1, 2024 · 8 comments · Fixed by #547
Closed

latest release doesn't contain precompiled binaries #542

kziemianek opened this issue Feb 1, 2024 · 8 comments · Fixed by #547

Comments

@kziemianek
Copy link

The links from documentation stopped working since last release.

https://taplo.tamasfe.dev/cli/installation/binary.html
example: https://github.com/tamasfe/taplo/releases/latest/download/taplo-linux-x86_64.gz .

We switched from latest to 0.8.1 in order to get binaries and use them in CI.
Is it possible to fix release so we can switch back to latest?

@kziemianek kziemianek changed the title latest release doesn't containt precompiled binaries latest release doesn't contain precompiled binaries Feb 1, 2024
@JounQin
Copy link
Collaborator

JounQin commented Feb 1, 2024

Sorry about this, I'll try to fix this issue.

@kziemianek
Copy link
Author

Sorry about this, I'll try to fix this issue.

All good, thanks! 👍🏼

@JounQin
Copy link
Collaborator

JounQin commented Feb 1, 2024

Sorry, this is because the release is published manually without CI. I'm not quite sure how to re-release, I'll try to remove the tag and recreate them manually.

@tamasfe
Copy link
Owner

tamasfe commented Feb 1, 2024

I'll try to remove the tag and recreate them manually.

Could be #275, which I believe could be caused by spam protection, at least on Gitlab it is documented that CI is triggered only if at most N tags are pushed at once, the same could be happening here as well.

@JounQin
Copy link
Collaborator

JounQin commented Feb 1, 2024

image

Invalid workflow file: .github/workflows/releases.yaml#L268

The workflow is not valid. .github/workflows/releases.yaml (Line: 268, Col: 19): Unrecognized named-value: 'env'. Located at position 1 within expression: env.RELEASE_VERSION .github/workflows/releases.yaml (Line: 270, Col: 19): Unrecognized named-value: 'env'. Located at position 1 within expression: env.RELEASE_VERSION

@tamasfe
Copy link
Owner

tamasfe commented Feb 1, 2024

Seems to be actions/runner#1189 I have no idea why/how it worked before and what changed.

@maresb
Copy link

maresb commented Feb 5, 2024

See #535 (comment). @nikaro writes:

Yep, looks like the release workflow is broken: https://github.com/tamasfe/taplo/actions/runs/7742605055/workflow#L268
And it seems to be my fault 😬 the env.RELEASE_VERSION variable is not available in the matrix.

@nikaro
Copy link
Contributor

nikaro commented Feb 5, 2024

My bad, I'm working on a PR.

Edit:
Here it is: #547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants