Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead. #20

Closed
ebhoren opened this issue May 5, 2017 · 5 comments

Comments

@ebhoren
Copy link

ebhoren commented May 5, 2017

I have this warning when running react-svg from create-react-app boilterplate.

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

Could you consider replacing this by below in src/index.js?
import React, { Component, PropTypes } from 'react'

to

import React, { Component } from 'react'
import PropTypes from 'prop-types'

Thanks in advance

@ianlyons
Copy link

Resolved with #23, just waiting for a maintainer 👍

@ianlyons
Copy link

@tanem do you have an idea of when you might be able to review the two open pulls? i don't really wanna fork this, but i understand if you guys are too busy

@Bleeky
Copy link

Bleeky commented May 23, 2017

Much needed update indeed ! This warning is not cool to look at 😄

@tanem
Copy link
Owner

tanem commented May 24, 2017

Hey all, sorry for the delay, been tied up on other things. Just looking at that PR now.

@tanem
Copy link
Owner

tanem commented May 24, 2017

Just pushed 2.1.20, should be all good now 👍

@tanem tanem closed this as completed May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants