Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No notification number in the bubble if Show only participating notifications is enabled #95

Open
darkred opened this issue May 1, 2020 · 0 comments

Comments

@darkred
Copy link
Contributor

darkred commented May 1, 2020

(follow-up to #89 (comment))

(Tested extension 20.4.22 in a fresh Chrome 81/Firefox 75 profile)

if I enable Show only participating notifications then the notification number in the bubble is no longer displayed, even if Show notification number in blue bubble remains enabled.

The following error is repeatedly shown in console :

(github-notifications-preview.js:386) 
Uncaught (in promise) TypeError: Cannot read property 'textContent' of null 
     at $i4sc$var$updateUnreadCount 

Screenshot comparison having Show only participating notifications :

Disabled --> notification number (4) is displayed ok

2020-05-01_214015

Enabled --> notification number (2) is missing

2020-05-01_214100

@fregante fregante marked this as a duplicate of #82 May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant