Skip to content

Commit

Permalink
New XML-based parameter class: pdParamXML
Browse files Browse the repository at this point in the history 
Another nasty project I've put off for far too long is standardizing
PD's internal parameter class (which tracks data passing between PD's
central processor and individual processing functions, so we can record
it for macros and the like) against PD's various file-specific
functions, which have all been migrated to XML.  This has been a blocker
for a bunch of tasks, including a built-in macro editor (for creating
macros without needing to actually *record* them).

I've now completed a pdParamXML class which is just about a drop-in
replacement for the old pdParamString class.  This class fixes a lot of
obnoxious interop issues, and it's also much better for
backwards-compatibility between versions, as individual processing
functions can track parameters by name instead of by ordinal (where
parameter changes are impossible to auto-detect).

The long-term goal is to remove all function-specific processing from
PD's central processor, and have it just blindly pass strings to/from
individual functions (instead of parsing out individual parameters, as
it does now).  Besides macro editing, this is also is a required change
before I can implement an official plugin module, but please note that
it's going to take some time to get everything switched.

Also, this will break macro backwards-compatibility for the 7.0 release.
Sorry.
  • Loading branch information
@tannerhelland
tannerhelland committed Jul 20, 2015
1 parent 4789ee7 commit c472bf0
Show file tree
Hide file tree
Showing 14 changed files with 597 additions and 289 deletions.
44 changes: 18 additions & 26 deletions App/PhotoDemon/Languages/Deutsch_1.xml
View file
Expand Up @@ -6,7 +6,7 @@

<langid>de-DE</langid>
<langname>Deutsch (Helmut Kuerbiss)</langname>
<langversion>6.7.59</langversion>
<langversion>6.7.61</langversion>
<langstatus>Complete</langstatus>

<author>Helmut Kuerbiss (orig. Frank Donckers)</author>
Expand Down Expand Up @@ -14146,27 +14146,7 @@ Sie können aber auch den Button "Bild öffnen" oben links oder
<translation></translation>
</phrase>

<phrase>
<original>forward diagonal</original>
<translation></translation>
</phrase>

<phrase>
<original>backward diagonal</original>
<translation></translation>
</phrase>

<phrase>
<original>cross</original>
<translation></translation>
</phrase>

<phrase>
<original>diagonal cross</original>
<translation></translation>
</phrase>

<!-- VBP_DialogBrushSettings.frm contains 23 phrases. 5 were duplicates of existing phrases, so only 18 new phrases were written to file. -->
<!-- VBP_DialogBrushSettings.frm contains 17 phrases. 3 were duplicates of existing phrases, so only 14 new phrases were written to file. -->

<!-- END text for VBP_DialogBrushSettings.frm-->

Expand Down Expand Up @@ -14280,12 +14260,24 @@ Sie können aber auch den Button "Bild öffnen" oben links oder

<!-- END text for VBP_DialogPenSettings.frm-->

<!-- BEGIN text for pdComboBox_Hatch.ctl -->

<!-- pdComboBox_Hatch.ctl contains 0 phrases. -->

<!-- END text for pdComboBox_Hatch.ctl-->

<!-- BEGIN text for pdParamXML.cls -->

<!-- pdParamXML.cls contains 0 phrases. -->

<!-- END text for pdParamXML.cls-->

<!-- Automatic text extraction complete. -->

<phrasecount>2479</phrasecount>
<phrasecount>2475</phrasecount>

<!-- As of this build, PhotoDemon contains 4252 phrases. -->
<!-- 1773 are duplicates, so only 2479 unique phrases have been written to file. -->
<!-- These 2479 phrases contain approximately 13769 total words. -->
<!-- As of this build, PhotoDemon contains 4246 phrases. -->
<!-- 1771 are duplicates, so only 2475 unique phrases have been written to file. -->
<!-- These 2475 phrases contain approximately 13762 total words. -->

</pdData>
44 changes: 18 additions & 26 deletions App/PhotoDemon/Languages/Deutsch_2.xml
View file
Expand Up @@ -6,7 +6,7 @@

<langid>de-DE</langid>
<langname>Deutsch (rk)</langname>
<langversion>6.7.60</langversion>
<langversion>6.7.62</langversion>
<langstatus>Nicht abgeschlossen</langstatus>

<author>rk (orig. Frank Donckers, Helmut Kuerbiss)</author>
Expand Down Expand Up @@ -14148,27 +14148,7 @@ oder das Menü "Datei > Öffnen" bzw. "Datei > Importieren".</translation>
<translation></translation>
</phrase>

<phrase>
<original>forward diagonal</original>
<translation></translation>
</phrase>

<phrase>
<original>backward diagonal</original>
<translation></translation>
</phrase>

<phrase>
<original>cross</original>
<translation></translation>
</phrase>

<phrase>
<original>diagonal cross</original>
<translation></translation>
</phrase>

<!-- VBP_DialogBrushSettings.frm contains 23 phrases. 5 were duplicates of existing phrases, so only 18 new phrases were written to file. -->
<!-- VBP_DialogBrushSettings.frm contains 17 phrases. 3 were duplicates of existing phrases, so only 14 new phrases were written to file. -->

<!-- END text for VBP_DialogBrushSettings.frm-->

Expand Down Expand Up @@ -14282,12 +14262,24 @@ oder das Menü "Datei > Öffnen" bzw. "Datei > Importieren".</translation>

<!-- END text for VBP_DialogPenSettings.frm-->

<!-- BEGIN text for pdComboBox_Hatch.ctl -->

<!-- pdComboBox_Hatch.ctl contains 0 phrases. -->

<!-- END text for pdComboBox_Hatch.ctl-->

<!-- BEGIN text for pdParamXML.cls -->

<!-- pdParamXML.cls contains 0 phrases. -->

<!-- END text for pdParamXML.cls-->

<!-- Automatic text extraction complete. -->

<phrasecount>2479</phrasecount>
<phrasecount>2475</phrasecount>

<!-- As of this build, PhotoDemon contains 4252 phrases. -->
<!-- 1773 are duplicates, so only 2479 unique phrases have been written to file. -->
<!-- These 2479 phrases contain approximately 13769 total words. -->
<!-- As of this build, PhotoDemon contains 4246 phrases. -->
<!-- 1771 are duplicates, so only 2475 unique phrases have been written to file. -->
<!-- These 2475 phrases contain approximately 13762 total words. -->

</pdData>
44 changes: 18 additions & 26 deletions App/PhotoDemon/Languages/Espanol.xml
View file
Expand Up @@ -6,7 +6,7 @@

<langid>es-MX</langid>
<langname>Español</langname>
<langversion>6.7.62</langversion>
<langversion>6.7.64</langversion>
<langstatus>completo</langstatus>

<author>Plinio C Garcia</author>
Expand Down Expand Up @@ -14148,27 +14148,7 @@ or los menús Archivo > Importar y Archivo > Abrir.</translation>
<translation></translation>
</phrase>

<phrase>
<original>forward diagonal</original>
<translation></translation>
</phrase>

<phrase>
<original>backward diagonal</original>
<translation></translation>
</phrase>

<phrase>
<original>cross</original>
<translation></translation>
</phrase>

<phrase>
<original>diagonal cross</original>
<translation></translation>
</phrase>

<!-- VBP_DialogBrushSettings.frm contains 23 phrases. 5 were duplicates of existing phrases, so only 18 new phrases were written to file. -->
<!-- VBP_DialogBrushSettings.frm contains 17 phrases. 3 were duplicates of existing phrases, so only 14 new phrases were written to file. -->

<!-- END text for VBP_DialogBrushSettings.frm-->

Expand Down Expand Up @@ -14282,12 +14262,24 @@ or los menús Archivo > Importar y Archivo > Abrir.</translation>

<!-- END text for VBP_DialogPenSettings.frm-->

<!-- BEGIN text for pdComboBox_Hatch.ctl -->

<!-- pdComboBox_Hatch.ctl contains 0 phrases. -->

<!-- END text for pdComboBox_Hatch.ctl-->

<!-- BEGIN text for pdParamXML.cls -->

<!-- pdParamXML.cls contains 0 phrases. -->

<!-- END text for pdParamXML.cls-->

<!-- Automatic text extraction complete. -->

<phrasecount>2479</phrasecount>
<phrasecount>2475</phrasecount>

<!-- As of this build, PhotoDemon contains 4252 phrases. -->
<!-- 1773 are duplicates, so only 2479 unique phrases have been written to file. -->
<!-- These 2479 phrases contain approximately 13769 total words. -->
<!-- As of this build, PhotoDemon contains 4246 phrases. -->
<!-- 1771 are duplicates, so only 2475 unique phrases have been written to file. -->
<!-- These 2475 phrases contain approximately 13762 total words. -->

</pdData>
44 changes: 18 additions & 26 deletions App/PhotoDemon/Languages/Francais.xml
View file
Expand Up @@ -6,7 +6,7 @@

<langid>fr-FR</langid>
<langname>français</langname>
<langversion>6.7.59</langversion>
<langversion>6.7.61</langversion>
<langstatus>Complete</langstatus>

<author>Frank Donckers</author>
Expand Down Expand Up @@ -14148,27 +14148,7 @@ ou la commande Fichier > Ouvrir et Fichier > Importer menu.</translation>
<translation></translation>
</phrase>

<phrase>
<original>forward diagonal</original>
<translation></translation>
</phrase>

<phrase>
<original>backward diagonal</original>
<translation></translation>
</phrase>

<phrase>
<original>cross</original>
<translation></translation>
</phrase>

<phrase>
<original>diagonal cross</original>
<translation></translation>
</phrase>

<!-- VBP_DialogBrushSettings.frm contains 23 phrases. 5 were duplicates of existing phrases, so only 18 new phrases were written to file. -->
<!-- VBP_DialogBrushSettings.frm contains 17 phrases. 3 were duplicates of existing phrases, so only 14 new phrases were written to file. -->

<!-- END text for VBP_DialogBrushSettings.frm-->

Expand Down Expand Up @@ -14282,12 +14262,24 @@ ou la commande Fichier > Ouvrir et Fichier > Importer menu.</translation>

<!-- END text for VBP_DialogPenSettings.frm-->

<!-- BEGIN text for pdComboBox_Hatch.ctl -->

<!-- pdComboBox_Hatch.ctl contains 0 phrases. -->

<!-- END text for pdComboBox_Hatch.ctl-->

<!-- BEGIN text for pdParamXML.cls -->

<!-- pdParamXML.cls contains 0 phrases. -->

<!-- END text for pdParamXML.cls-->

<!-- Automatic text extraction complete. -->

<phrasecount>2479</phrasecount>
<phrasecount>2475</phrasecount>

<!-- As of this build, PhotoDemon contains 4252 phrases. -->
<!-- 1773 are duplicates, so only 2479 unique phrases have been written to file. -->
<!-- These 2479 phrases contain approximately 13769 total words. -->
<!-- As of this build, PhotoDemon contains 4246 phrases. -->
<!-- 1771 are duplicates, so only 2475 unique phrases have been written to file. -->
<!-- These 2475 phrases contain approximately 13762 total words. -->

</pdData>
44 changes: 18 additions & 26 deletions App/PhotoDemon/Languages/Indonesian.xml
View file
Expand Up @@ -6,7 +6,7 @@

<langid>id-ID</langid>
<langname>Indonesian</langname>
<langversion>6.6.1</langversion>
<langversion>6.6.3</langversion>
<langstatus>Complete</langstatus>

<author>Ari Sohandri Putra</author>
Expand Down Expand Up @@ -14153,27 +14153,7 @@ atau menu berkas >buka dan berkas > menu impor.</translation>
<translation></translation>
</phrase>

<phrase>
<original>forward diagonal</original>
<translation></translation>
</phrase>

<phrase>
<original>backward diagonal</original>
<translation></translation>
</phrase>

<phrase>
<original>cross</original>
<translation></translation>
</phrase>

<phrase>
<original>diagonal cross</original>
<translation></translation>
</phrase>

<!-- VBP_DialogBrushSettings.frm contains 23 phrases. 5 were duplicates of existing phrases, so only 18 new phrases were written to file. -->
<!-- VBP_DialogBrushSettings.frm contains 17 phrases. 3 were duplicates of existing phrases, so only 14 new phrases were written to file. -->

<!-- END text for VBP_DialogBrushSettings.frm-->

Expand Down Expand Up @@ -14287,12 +14267,24 @@ atau menu berkas >buka dan berkas > menu impor.</translation>

<!-- END text for VBP_DialogPenSettings.frm-->

<!-- BEGIN text for pdComboBox_Hatch.ctl -->

<!-- pdComboBox_Hatch.ctl contains 0 phrases. -->

<!-- END text for pdComboBox_Hatch.ctl-->

<!-- BEGIN text for pdParamXML.cls -->

<!-- pdParamXML.cls contains 0 phrases. -->

<!-- END text for pdParamXML.cls-->

<!-- Automatic text extraction complete. -->

<phrasecount>2479</phrasecount>
<phrasecount>2475</phrasecount>

<!-- As of this build, PhotoDemon contains 4252 phrases. -->
<!-- 1773 are duplicates, so only 2479 unique phrases have been written to file. -->
<!-- These 2479 phrases contain approximately 13769 total words. -->
<!-- As of this build, PhotoDemon contains 4246 phrases. -->
<!-- 1771 are duplicates, so only 2475 unique phrases have been written to file. -->
<!-- These 2475 phrases contain approximately 13762 total words. -->

</pdData>

0 comments on commit c472bf0

Please sign in to comment.