Skip to content

Commit

Permalink
Reinstate color management for the main viewport
Browse files Browse the repository at this point in the history 
I wanted to do this before proceeding with paint tools, because I need
to know what kind of delay is induced by problematic ICC profiles (like
those generated by the stupid Windows "calibrate your monitor without
using professional tools!" Control Panel applet).

Maximum delay across my set of test profiles is ~15-25 ms, with
professionally constructed profiles coming in closer to ~10 ms.  This is
an excellent result, and significantly better than the old Windows ICM
engine (which frequently hit delays over 100 ms, especially on profiles
constructed by Windows).

Note that users who don't want a color-managed display can now
deactivate the engine entirely from the Tools > Options dialog.  This
will provide a performance boost, and if your display is close to sRGB
anyway, it might be worth it.

Next up is restoring color management to elements like the image
tabstrip and the color selection tools.

Thank you also to Roy K and ChenLin for contributing updated translation
files to this patch.
  • Loading branch information
@tannerhelland
tannerhelland committed Nov 29, 2016
1 parent 12c0181 commit e2664d0
Show file tree
Hide file tree
Showing 32 changed files with 1,504 additions and 1,412 deletions.
64 changes: 32 additions & 32 deletions App/PhotoDemon/Languages/Croatian.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<langid>hr-HR</langid>
<langname>Croatian</langname>
<langversion>6.8.1981</langversion>
<langversion>6.8.2033</langversion>
<langstatus>raw machine translation</langstatus>

<author>Google Translator</author>
Expand Down Expand Up @@ -1118,7 +1118,7 @@ To omogućiti podršku za komprimirani PDI datoteke, kliknite Pomoć> Provjeri a

<phrase>
<original>Erase</original>
<translation></translation>
<translation>brisati</translation>
</phrase>

<phrase>
Expand All @@ -1128,22 +1128,22 @@ To omogućiti podršku za komprimirani PDI datoteke, kliknite Pomoć> Provjeri a

<phrase>
<original>Locked</original>
<translation></translation>
<translation>Zaključan</translation>
</phrase>

<phrase>
<original>Perceptual</original>
<translation></translation>
<translation>Perceptivna</translation>
</phrase>

<phrase>
<original>Relative colorimetric</original>
<translation></translation>
<translation>relativna Kolorimctrijski</translation>
</phrase>

<phrase>
<original>Absolute colorimetric</original>
<translation></translation>
<translation>Apsolutna Kolorimctrijski</translation>
</phrase>

<phrase>
Expand Down Expand Up @@ -1548,12 +1548,12 @@ In verzije 6.0 podržava, PhotoDemon makro datoteke su redizajnirani kako bi pod

<phrase>
<original>Paint stroke</original>
<translation></translation>
<translation>Boja moždani udar</translation>
</phrase>

<phrase>
<original>Paint layer</original>
<translation></translation>
<translation>sloj boje</translation>
</phrase>

<!-- Paintbrush.bas contains 4 phrases. 2 were duplicates of existing phrases, so only 2 new phrases were written to file. -->
Expand Down Expand Up @@ -3336,7 +3336,7 @@ Please enter a numeric value.</original>
<translation>Traženi odabir datoteka nije pronađena. opterećenje Izbor napušten.</translation>
</phrase>

<!-- pdSelection.cls contains 5 phrases. 4 were duplicates of existing phrases, so only one new phrase was written to file. -->
<!-- pdSelection.cls contains 1 phrase. The phrase was unique, so 1 new phrase was written to file. -->

<!-- END text for pdSelection.cls-->

Expand Down Expand Up @@ -4174,7 +4174,7 @@ or the File > Open and File > Import menus.</original>

<phrase>
<original>original</original>
<translation></translation>
<translation>izvornik</translation>
</phrase>

<!-- pdNewOld.ctl contains 4 phrases. 2 were duplicates of existing phrases, so only 2 new phrases were written to file. -->
Expand Down Expand Up @@ -13245,27 +13245,27 @@ To omogućiti podršku za ovu značajku, molimo kopirajte FreeImage.dll podnijet

<phrase>
<original>alpha mode</original>
<translation></translation>
<translation>alfa način</translation>
</phrase>

<phrase>
<original>preview quality</original>
<translation></translation>
<translation>kvaliteta pregled</translation>
</phrase>

<phrase>
<original>Best quality</original>
<translation></translation>
<translation>Najbolja kvaliteta</translation>
</phrase>

<phrase>
<original>Default</original>
<translation></translation>
<translation>Zadano</translation>
</phrase>

<phrase>
<original>Best performance</original>
<translation></translation>
<translation>Najbolja predstava</translation>
</phrase>

<!-- Toolpanel_Paintbrush.frm contains 8 phrases. 3 were duplicates of existing phrases, so only 5 new phrases were written to file. -->
Expand Down Expand Up @@ -14127,37 +14127,37 @@ To continue, please download a fresh copy of PhotoDemon from photodemon.org.</or

<phrase>
<original>display rendering intent</original>
<translation></translation>
<translation>Prikaz renderiranje namjera</translation>
</phrase>

<phrase>
<original>available displays</original>
<translation></translation>
<translation>Dostupno prikazuje</translation>
</phrase>

<phrase>
<original>turn off display color management</original>
<translation></translation>
<translation>isključivanje zaslona upravljanje bojama</translation>
</phrase>

<phrase>
<original>use the current system profiles for each display</original>
<translation></translation>
<translation>korištenje trenutne profile sustava za svaki prikaz</translation>
</phrase>

<phrase>
<original>color profile for this display</original>
<translation></translation>
<translation>Profil boja za ovaj prikaz</translation>
</phrase>

<phrase>
<original>display policies</original>
<translation></translation>
<translation>pravila za prikaz</translation>
</phrase>

<phrase>
<original>use custom profiles for each display</original>
<translation></translation>
<translation>koristiti prilagođene profile za svaku zaslonu</translation>
</phrase>

<phrase>
Expand Down Expand Up @@ -14382,7 +14382,7 @@ To continue, please download a fresh copy of PhotoDemon from photodemon.org.</or

<phrase>
<original>main window</original>
<translation></translation>
<translation>glavni prozor</translation>
</phrase>

<phrase>
Expand Down Expand Up @@ -14436,17 +14436,17 @@ Are you sure you want to continue?</original>

<phrase>
<original>compact - image names only</original>
<translation></translation>
<translation>samo nazivi slika - kompaktan</translation>
</phrase>

<phrase>
<original>descriptive - full image locations, including folder(s)</original>
<translation></translation>
<translation>opisno - punu sliku lokacije, uključujući mapu (e)</translation>
</phrase>

<phrase>
<original>The title bar of the main PhotoDemon window displays information about the currently loaded image. Use this preference to control how much information is displayed.</original>
<translation></translation>
<translation>Naslov bar glavnom prozoru PhotoDemon prikazuje informacije o trenutno učitava slike. Koristite ovu postavku za kontrolu koliko informacija se prikazuje.</translation>
</phrase>

<phrase>
Expand Down Expand Up @@ -14626,7 +14626,7 @@ Are you sure you want to continue?</original>

<phrase>
<original>Turning off display color management can provide a small performance boost. If your display is not currently configured for color management, use this setting.</original>
<translation></translation>
<translation>Isključivanje prikaza upravljanje bojama mogu dati mali performanse. Ako vaš zaslon trenutno nije konfiguriran za upravljanje bojama, koristite ovu postavku.</translation>
</phrase>

<phrase>
Expand All @@ -14651,7 +14651,7 @@ Are you sure you want to continue?</original>

<phrase>
<original>If you do not know what this setting controls, set it to "Perceptual". Perceptual rendering intent is the best choice for most users.</original>
<translation></translation>
<translation>Ako ne znate što je ovo podešavanje kontrole, postavite ga na "opa'ajne". Perceptivna renderiranje Namjera je najbolji izbor za većinu korisnika.</translation>
</phrase>

<phrase>
Expand Down Expand Up @@ -14815,12 +14815,12 @@ If dalje onemogućite ažuriranja, ne zaboravite posjetiti photodemon.org s vrem

<phrase>
<original>Color management options control how PhotoDemon uses ICC profiles for image files and devices.</original>
<translation></translation>
<translation>Opcije upravljanja bojama kontrolirati kako PhotoDemon koristi ICC profile za slikovnih datoteka i uređaja.</translation>
</phrase>

<phrase>
<original>Color Management Options</original>
<translation></translation>
<translation>Mogućnosti upravljanja bojama</translation>
</phrase>

<phrase>
Expand Down Expand Up @@ -14972,8 +14972,8 @@ If dalje onemogućite ažuriranja, ne zaboravite posjetiti photodemon.org s vrem

<phrasecount>2538</phrasecount>

<!-- As of this build, PhotoDemon contains 4472 phrases. -->
<!-- 1934 are duplicates, so only 2538 unique phrases have been written to file. -->
<!-- As of this build, PhotoDemon contains 4468 phrases. -->
<!-- 1930 are duplicates, so only 2538 unique phrases have been written to file. -->
<!-- These 2538 phrases contain approximately 12764 total words. -->

</pdData>
Loading

2 comments on commit e2664d0

@Kroc
Copy link
Contributor

@Kroc Kroc commented on e2664d0 Nov 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's very handy being able to disable the colour-management engine entirely as for web-work you're better off stripping all colour management entirely to avoid mismatching of CSS & PNG colours. Will the option be available in the menu, as it's something I'd want to toggle regularly?

@tannerhelland
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the option be available in the menu, as it's something I'd want to toggle regularly?

Yes. Once soft-proofing is implemented, the View menu will receive new options to match, including quick links for common display modes (including an unmanaged display).

That said, when doing webwork you definitely want your display to still be color-managed. Display color management is a non-destructive setting that simply compensates for any weaknesses in your display hardware. (For example, if you're doing webwork on a crappy old netbook screen, a proper color-managed display will over-saturate the colors to compensate for the weak screen, so you get an experience closer to high-end display.) It has zero bearing on the underlying image colors.

What you don't want for web work is a working space other than sRGB. At present, PD is hard-coded to use sRGB as its working space. This will be changing in the coming weeks, but sRGB will always be the program's default as it's by far the best setting for casual users.

Please sign in to comment.