-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Testing Suite #42
Comments
Yep! I’d like to use React-testing-library and jest. Only testing actual user api, no internals. Just follow the Kent C Dodd’s example.
Tanner Linsley
…On Nov 16, 2019, 1:02 PM -0700, Amit Ripshtos ***@***.***>, wrote:
Hey!
I really loved the package and it's API, and I think in order to make the contribution easier we should write up tests for the hooks and other functions.
How should we progress there? Maybe create an infrastructure to the testing and I will help writing some tests? I saw swr's tests and there is a lot in common and we can learn from their testing.
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
tannerlinsley
changed the title
[Feature request] Writing tests
[Feature request] Testing Suite
Nov 19, 2019
Looks like testing has now been set up at least. Closing this as we ramp up testing |
@tannerlinsley are there any examples of testing with react-hooks-testing-library? I looked through the code base and it looks like all of the tests are wrapped in components. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey!
I really loved the package and it's API, and I think in order to make the contribution easier we should write up tests for the hooks and other functions.
How should we progress there? Maybe create an infrastructure to the testing and I will help writing some tests? I saw swr's tests and there is a lot in common and we can learn from their testing.
Thanks!
The text was updated successfully, but these errors were encountered: