Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Testing Suite #42

Closed
amitripshtos opened this issue Nov 16, 2019 · 3 comments
Closed

[Feature request] Testing Suite #42

amitripshtos opened this issue Nov 16, 2019 · 3 comments

Comments

@amitripshtos
Copy link
Contributor

Hey!
I really loved the package and it's API, and I think in order to make the contribution easier we should write up tests for the hooks and other functions.

How should we progress there? Maybe create an infrastructure to the testing and I will help writing some tests? I saw swr's tests and there is a lot in common and we can learn from their testing.

Thanks!

@tannerlinsley
Copy link
Collaborator

tannerlinsley commented Nov 16, 2019 via email

@tannerlinsley tannerlinsley changed the title [Feature request] Writing tests [Feature request] Testing Suite Nov 19, 2019
@tannerlinsley
Copy link
Collaborator

Looks like testing has now been set up at least. Closing this as we ramp up testing

@antgonzales
Copy link
Contributor

@tannerlinsley are there any examples of testing with react-hooks-testing-library? I looked through the code base and it looks like all of the tests are wrapped in components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants