exhaustive-deps doesn't understand function call for query key

[fdw]

Describe the bug

We want to offer comfort hooks to query and invalidate calls. Of course, they need to use the same query key, so we extracted it like this:

export function useSomeData(id: number) = useQuery({
  queryKey: queryKeyFor(id),
  queryFn: ...
})

export function useQueryCache() {
  const queryClient = useQueryClient()
  return {
    invalidate: (id: number) =>
      queryClient.invalidateQueries({ queryKey: queryKeyFor(id) })
  }
}

function queryKeyFor(id: number) {
  return ['api', id]
}

In practice, this works perfectly. However, the eslint-plugin exhaustive-deps doesn't understand that id is contained in the query key.

Your minimal, reproducible example

n/a

Steps to reproduce

see above

Expected behavior

I expect the hook to understand that id is used in the query key factory, but it's not.

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

• OS: Linux
• Browser: n/a

Tanstack Query adapter

react-query

TanStack Query version

@tanstack/eslint-plugin-query@5.20.1

TypeScript version

5.3.3

Additional context

No response

[TkDodo]

we have tests for this, so please show a reproduction:

query/packages/eslint-plugin-query/src/__tests__/exhaustive-deps.test.ts

Lines 142 to 156 in 7b7cc2f

	{
	name: 'should not fail when queryKey is a queryKeyFactory while having a dep as first arg',
	code: normalizeIndent`
	const fooQueryKeyFactory = {
	foo: () => ['foo'] as const,
	num: (num: number) => [...fooQueryKeyFactory.foo(), num] as const,
	}
	const useFoo = (num: number) =>
	useQuery({
	queryKey: fooQueryKeyFactory.foo(num),
	queryFn: () => Promise.resolve(num),
	})
	`,
	},

[fdw]

Here's a reproduction: https://stackblitz.com/edit/vitejs-vite-hutlfq?file=src%2Fhooks.ts
The issue seems to be more subtly about undefined and coalescing. Maybe you have a better idea how to solve this :)

[TkDodo]

thanks for the reproduction. it really seems to be a bug around ??.

This yields no lint error:

queryKey: `blah${id}`,

but this does:

queryKey: `blah${id ?? -1}`,

@Newbie012 could you have a look at this?

[fdw]

That was quick! Thank you very much!