Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dots in Validation error message are stripped #109

Closed
simonbuehler opened this issue Feb 7, 2022 · 6 comments
Closed

Dots in Validation error message are stripped #109

simonbuehler opened this issue Feb 7, 2022 · 6 comments

Comments

@simonbuehler
Copy link
Contributor

Hi,

spent some time on localisation 'fixing' until i noticed that it was working as expected but tall-forms is swallowing the dots in the date message.

grafik

livewire returns with dots but here

return \Str::of($message)->remove('.')->replaceFirst('form_data', '')->replaceFirst('form data', '')->__toString();

they get removed

@tanthammar
Copy link
Owner

That needs some thinking. Can you work around it by setting a custom error message for that field?

@simonbuehler
Copy link
Contributor Author

Actually this would not show the date german format which is a downer, i guess the check for array/repeater should be a bit smarter

@tanthammar
Copy link
Owner

I'll run some tests tomorrow. It might be so that I can remove the method.
It is from a previous version before the package had a validation attributes getter.

Can't promise it'll be solved by tomorrow but I'll do my best:)

@tanthammar
Copy link
Owner

@simonbuehler which version of TALL-forms are you using? The ErrorMessage.php is not used anymore. (except in file upload)
The validation attributes are set in ValidatesFields, fieldValidationAttributes()

@tanthammar
Copy link
Owner

Closing due to inactivity.

@simonbuehler
Copy link
Contributor Author

simonbuehler commented Feb 28, 2022

thanks, i'll update and test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants