Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename, when several launching activities in one app #415

Open
mariohuq opened this issue Oct 28, 2023 · 4 comments
Open

Rename, when several launching activities in one app #415

mariohuq opened this issue Oct 28, 2023 · 4 comments
Labels
good first issue Good for newcomers

Comments

@mariohuq
Copy link

Version: 4.1.5

If the app has two separate launching shortcuts, for example this,
and you rename one of them in Olauncher,

(actual behavior)

  1. the other shortcut is renamed too
  2. you cannot undo renaming even if you reinstall the app.

Expected behaviour:

  1. Other shortcuts are unaffected when renamed one of them
  2. Renames are not stored for uninstalled apps
@mariohuq
Copy link
Author

mariohuq commented Oct 28, 2023

I think, that problem lies in

fun getAppRenameLabel(appPackage: String): String = prefs.getString(appPackage, "").toString()

@tanujnotes
Copy link
Owner

I'm aware of the issue. It's low priority though.

@tanujnotes tanujnotes added the good first issue Good for newcomers label Oct 29, 2023
@mariohuq
Copy link
Author

@tanujnotes would you review if I made a pull request with a fix for that?

@tanujnotes
Copy link
Owner

@mariohuq Yes, that'd be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants