Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Haptic Feedback #172

Closed
wants to merge 2 commits into from
Closed

Enable Haptic Feedback #172

wants to merge 2 commits into from

Conversation

shalzz
Copy link

@shalzz shalzz commented Mar 10, 2022

No description provided.

@Ilithy
Copy link

Ilithy commented Mar 29, 2022

Hi @shalzz If I may ask, with this PR, is the activation or deactivation of the haptic feedback only managed by the operating system?

Thank you, my apologies for the inconvenience

@shalzz
Copy link
Author

shalzz commented Mar 29, 2022

Hi @shalzz If I may ask, with this PR, is the activation or deactivation of the haptic feedback only managed by the operating system?

Thank you, my apologies for the inconvenience

If there is an option of disabling system-wide vibration/haptic feedback, then this PR should respect that. Let me know if it doesn't.

@Ilithy
Copy link

Ilithy commented Mar 29, 2022

@shalzz After checking the haptic feedback is indeed totally managed by Android directly. it is possible to override these system settings, but in this case, it is not necessary in my opinion.
Your PR is perfect; if it is possible (and if it suits you) it will be possible to perform this PR on the fork https://github.com/jooooscha/Olauncher?

Thanks

@jooooscha
Copy link

I would gladly accept this PR :)

@shalzz
Copy link
Author

shalzz commented May 11, 2022

@jooooscha You can already pull in my commits. A PR is just a github specific concept.

@jooooscha
Copy link

jooooscha commented May 11, 2022

If you could open an PR, that would reduce the work for me. Also would it be easier to merge it into my code base and add an enable option to the settings

@Ilithy
Copy link

Ilithy commented Jun 6, 2022

@jooooscha I made the PR (OlauncherCF/OlauncherCF#50) by copying the work of @shalzz
Sorry I can't do more, I don't know how to add the activation/deactivation option in Olauncher CF settings :-/

@tanujnotes
Copy link
Owner

Haptic feedback was there in older versions but people complained about it being irritating.
Problem with haptic feedback is that the intensity is different on different phone models. While it is barely noticeable on my Samsung, it can vibrate violently on a Xiaomi device. For these reasons, we're skipping this it. All this has already been communicated to creator of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants