Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the document API #103

Closed
ricardojmendez opened this issue Oct 2, 2016 · 1 comment
Closed

Add support for the document API #103

ricardojmendez opened this issue Oct 2, 2016 · 1 comment

Comments

@ricardojmendez
Copy link
Collaborator

We don't yet support the "new" document API. Spinning this out from #91, see this comment for more details.

@joelittlejohn
Copy link
Collaborator

The Document API provides a much more pleasant interaction model for Java developers, however since we're already free to work with 'documents' in Clojureland (our edn literals) I think there's limited value in switching Faraday to the document API. Faraday is already giving developers an experience akin to the document API.

It could simplify some of the Faraday internals to use the Document API but would also carry a performance cost. If we decided to support both APIs (two different Faraday modes) we'd have a lot more code to maintain here.

I'm going to close this one but we're certainly open to ideas about why it might be good to revisit this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants