Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MACS2 default q-value different in README vs using MACS2 #184

Open
rebeccawh opened this issue Apr 10, 2017 · 3 comments
Open

MACS2 default q-value different in README vs using MACS2 #184

rebeccawh opened this issue Apr 10, 2017 · 3 comments

Comments

@rebeccawh
Copy link

rebeccawh commented Apr 10, 2017

MACS2 is wonderful, thank-you for it. I hope it becomes a paper to be referenced at some point.

I've only just noticed that while the README says the default q-vlaue is 0.01, that in the MACS2 (2.1.0) output the default q-value is 0.05. The README indicates that 0.01 is good for strong peaks, while the 0.05 is more for broad/weaker peaks. Yet I found the output of someone asking a question about MACS2 and MACS2's output said the opposite.
# qvalue cutoff for narrow/strong regions = 5.00e-02
# qvalue cutoff for broad/weak regions = 1.00e-02

I am now rather unsure whether I have been processing all my DNase-seq and ATAC-seq with the wrong q-value or the right one. The choice of q-value has quite an impact on the regions that are reported.


Also, I was wondering if it was possible to report more decimal places for the q-value or p-value. I've been trying to use IDR with MACS2 and I am wondering if the large number of ties due to only 5 decimal places is causing some problems.

thank-you for any advice on this,
Rebecca

@IanCodes
Copy link

IanCodes commented Apr 10, 2017 via email

@rebeccawh
Copy link
Author

Thank-you but I don't have access to the MACS paper you linked. Also a number of things changed in MACS relative to MACS2 and I believe threshold was one. Additionally, what I wrote above about qval < 0.01 vs. qval < 0.05 is contradictory within MACS2 itself i.e. within the MACS2 README vs the output of MACS2.

@taoliu
Copy link
Contributor

taoliu commented May 5, 2017

@rebeccawh The default is q=0.05. I haven't carefully edited MACS2 README file. The output from command line is the actual parameter. You can also confirm the parameters from MACS2 running message or the header of xls file.

taoliu added a commit that referenced this issue May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants