refactor: use ES2015 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demurgos
force-pushed
the
es2015
branch
3 times, most recently
from
2566b83
to
b063250
Compare
This was referenced Oct 10, 2018
|
+1, but this has conflicts with master, please rebase. |
|
@demurgos do you have a chance to work on this? |
|
Thanks for the reminder @coreyfarrell |
|
I rebased the PR and fixed the conflicts. The only change was in the |
|
I am looking into the errors: they seem to also be present on |
|
CI is failing on Node 6 because |
# Why Following tapjs#24, the library requires Node 6. This allows to use ES2015 features to make the code more expressive and easier to maintain. # What Replace `var` declarations by `const` or `let`. Use arrow functions. Replace `arguments` slicing with rest arguments. Use `Map` to store the listeners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Following #24, the library requires Node 6. This allows to use ES2015 features to make the code more expressive and easier to maintain.
What
Replace
vardeclarations byconstorlet. Use arrow functions. Replaceargumentsslicing with rest arguments. UseMapto store the listeners.